josh-mckenzie commented on a change in pull request #1377:
URL: https://github.com/apache/cassandra/pull/1377#discussion_r779775822
##########
File path:
test/unit/org/apache/cassandra/db/compaction/CompactionExecutorTest.java
##########
@@ -63,44 +70,43 @@ public void destroy() throws Exception
executor.awaitTermination(1, TimeUnit.MINUTES);
}
+ void awaitExecution() throws Exception
+ {
+ assert afterExecuteCompleted.await(10, TimeUnit.SECONDS) :
"afterExecute failed to complete";
Review comment:
You're absolutely right. I was thinking it was sleeping 10 seconds and
that's why you moved to a 10 second timeout on the signal wait; totally spaced
that sleep's ms. 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]