bereng commented on pull request #1380: URL: https://github.com/apache/cassandra/pull/1380#issuecomment-1014266010
Hi, good job this looks very promising imo. I would also add tests in `ColumnConditionTest` and check other test classes that might apply. I would also add tests for corner cases like empty collections and such similar scenarios. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
