bereng commented on a change in pull request #1168:
URL: https://github.com/apache/cassandra/pull/1168#discussion_r789375343
##########
File path: src/java/org/apache/cassandra/db/commitlog/CommitLogReplayer.java
##########
@@ -436,16 +455,23 @@ public void handleMutation(Mutation m, int size, int
entryLocation, CommitLogDes
sawCDCMutation = true;
pendingMutationBytes += size;
+
+ boolean isSchemaMutation =
SchemaConstants.isSchemaKeyspace(m.getKeyspaceName());
+
+ if (isSchemaMutation)
+ writeOrder.awaitNewBarrier();
Review comment:
Nice thinking about adding logging to the rule I'll try to remember
that. This will check for any schema reload that might happen, not for the
commit log replay specific ones correct? But I don't think there's a way to
tell them apart even if we moved the barrier await to it's own method. So this
is better than nothing imo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
