yifan-c commented on pull request #1168: URL: https://github.com/apache/cassandra/pull/1168#issuecomment-1018722513
> Hi, @adelapena. Firstly, thanks for the patch. > > If my understanding is correct, the fix is to divide the mutations by schema change into multiple groups. What concerns me is that the schema change is replayed along with the other mutations in the group in parallel. It is possible that some mutations gets dropped because the schema change is replayed out of order or take more time to be applied. > > I have a hacky reproduction that test replay a create table mutation followed with mutations to insert rows. The subsequent mutations are expected to be applied, but they are in fact not. See [yifan-c@81b52b4](https://github.com/yifan-c/cassandra/commit/81b52b42e3b6db99989664323790b782aafdf9c5) > > I think the schema change should be in its own group. My test is not representative for the logic in `handleMutation`, which does await for the schema change mutation to finish before submitting new mutations. I missed the condition in the while loop. Sorry for any confusion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
