adelapena commented on a change in pull request #1168:
URL: https://github.com/apache/cassandra/pull/1168#discussion_r790763987
##########
File path: src/java/org/apache/cassandra/db/commitlog/CommitLogReplayer.java
##########
@@ -436,16 +455,23 @@ public void handleMutation(Mutation m, int size, int
entryLocation, CommitLogDes
sawCDCMutation = true;
pendingMutationBytes += size;
+
+ boolean isSchemaMutation =
SchemaConstants.isSchemaKeyspace(m.getKeyspaceName());
+
+ if (isSchemaMutation)
+ writeOrder.awaitNewBarrier();
Review comment:
Yes, this will verify any schema reload, and starting the node would
involve multiple schema reloads (and delays) because all the schema is
replayed, not only our changes. We don't have an easy way to distinguish our
own changes in the schema but we know that we are delaying all schema updates.
As for knowing that our schema changes are being replayed, this is
implicitly verified by the last query, which is based on the new schema. To be
sure we can do the query with and without explicit column names, so we know
that the table has the right columns after replaying the schema mutations,
[this
way](https://github.com/apache/cassandra-dtest/pull/155/commits/7532f8ab939d26daa2cdcc024e67d47f872037dd).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
