ekaterinadimitrova2 commented on a change in pull request #1421: URL: https://github.com/apache/cassandra/pull/1421#discussion_r792086616
########## File path: src/java/org/apache/cassandra/db/virtual/CQLMetricsTable.java ########## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.db.virtual; + +import com.google.common.annotations.VisibleForTesting; + +import org.apache.cassandra.db.marshal.DoubleType; +import org.apache.cassandra.db.marshal.UTF8Type; +import org.apache.cassandra.dht.LocalPartitioner; +import org.apache.cassandra.metrics.CQLMetrics; +import org.apache.cassandra.schema.TableMetadata; +import org.apache.cassandra.cql3.QueryProcessor; + +// Virtual table for CQL metrics Review comment: `I feel comments are like chocolates, like to have as many as we can :-)` Wow, how did you know I am a chocoholic :D Jokes aside, while I agree with you and unfortunately, we lack them often, in this case we just repeat things that are on the next line - like in this case you see it is Virtual Table and the CQL metrics is in the name. I don't mean to be super particular here but I know other engineers on the project are serious on that (talking from experience from my own reviews where I tended to put a lot of comments sometimes :D ) so just saying. Also, in this case these comments are probably not at places that we expect a lot of code changes but according to the Clean Code rules - if we can make the code self explanatory that is the best (I think you already have that quite well done), better to skip them as in time with code changes, comments get pulled away from where they were meant to refer to and it becomes confusing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
