ekaterinadimitrova2 commented on a change in pull request #1425:
URL: https://github.com/apache/cassandra/pull/1425#discussion_r793859488
##########
File path: src/java/org/apache/cassandra/db/virtual/SettingsTable.java
##########
@@ -49,6 +49,13 @@
.filter(f -> !Modifier.isStatic(f.getModifiers()))
.collect(Collectors.toMap(Field::getName, Functions.identity()));
+ @VisibleForTesting
+ static final Map<String, Field> ANNOTATED_FIELDS =
+ Arrays.stream(Config.class.getFields())
Review comment:
For the record, I changed this one locally to:
```
@VisibleForTesting
static final Map<String, Field> ANNOTATED_FIELDS =
Arrays.stream(Config.class.getFields())
.filter(f ->
!Modifier.isStatic(f.getModifiers()))
.filter(f ->
f.isAnnotationPresent(Replaces.class))
.collect(Collectors.toMap(Field::getName, Functions.identity()));
```
##########
File path: src/java/org/apache/cassandra/db/virtual/SettingsTable.java
##########
@@ -49,6 +49,13 @@
.filter(f -> !Modifier.isStatic(f.getModifiers()))
.collect(Collectors.toMap(Field::getName, Functions.identity()));
+ @VisibleForTesting
+ static final Map<String, Field> ANNOTATED_FIELDS =
+ Arrays.stream(Config.class.getFields())
Review comment:
For the record, I changed this one locally to:
```
@VisibleForTesting
static final Map<String, Field> ANNOTATED_FIELDS =
Arrays.stream(Config.class.getFields())
.filter(f ->
!Modifier.isStatic(f.getModifiers()))
.filter(f ->
f.isAnnotationPresent(Replaces.class))
.collect(Collectors.toMap(Field::getName, Functions.identity()));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
