ekaterinadimitrova2 commented on a change in pull request #1421: URL: https://github.com/apache/cassandra/pull/1421#discussion_r795763626
########## File path: src/java/org/apache/cassandra/db/virtual/CQLMetricsTable.java ########## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.db.virtual; + +import com.google.common.annotations.VisibleForTesting; + +import org.apache.cassandra.db.marshal.DoubleType; +import org.apache.cassandra.db.marshal.UTF8Type; +import org.apache.cassandra.dht.LocalPartitioner; +import org.apache.cassandra.metrics.CQLMetrics; +import org.apache.cassandra.schema.TableMetadata; +import org.apache.cassandra.cql3.QueryProcessor; + + +final class CQLMetricsTable extends AbstractVirtualTable +{ + public static final String TABLE_NAME = "cql_metrics"; + public static final String PREPARED_STATEMENTS_COUNT = "prepared_statements_count"; + public static final String PREPARED_STATEMENTS_EVICTED = "prepared_statements_evicted"; + public static final String PREPARED_STATEMENTS_EXECUTED = "prepared_statements_executed"; + public static final String PREPARED_STATEMENTS_RATIO = "prepared_statements_ratio"; + public static final String REGULAR_STATEMENTS_EXECUTED = "regular_statements_executed"; + public static final String NAME_COL = "name"; + public static final String VALUE_COL = "value"; + + private final CQLMetrics cqlMetrics; + + CQLMetricsTable(String keyspace) + { + this(keyspace, QueryProcessor.metrics); + } + + // For dependency injection + @VisibleForTesting + CQLMetricsTable(String keyspace, CQLMetrics cqlMetrics) + { + super(TableMetadata.builder(keyspace, TABLE_NAME) + .kind(TableMetadata.Kind.VIRTUAL) Review comment: I think I missed one thing here, let's add a table description, the way it is done here for example: https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/virtual/RolesCacheKeysTable.java#L33 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
