belliottsmith commented on a change in pull request #1:
URL: https://github.com/apache/cassandra-accord/pull/1#discussion_r798735768
##########
File path: accord-core/src/main/java/accord/api/ConfigurationService.java
##########
@@ -0,0 +1,56 @@
+package accord.api;
+
+import accord.local.Node;
+import accord.topology.Topology;
+
+/**
+ * Cluster configuration service. Manages linearizable cluster configuration
changes. Any node reporting a
+ * configuration with epoch n is guaranteed to have previously seen applied
every previous epoch configuration
+ */
+public interface ConfigurationService
+{
+ interface Listener
+ {
+ /**
+ * Informs listeners of new topology. This is guaranteed to be called
sequentially for each epoch after
+ * the initial topology returned by `currentTopology` on startup.
+ */
+ void onTopologyUpdate(Topology topology);
+
+ /**
+ * Called when accord data associated with a superseded epoch has been
sync'd across current replicas
+ */
+ void onEpochSyncComplete(Node.Id node, long epoch);
Review comment:
Maybe add some additional explanation about what implementations need to
guarantee before they invoke this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
