bereng commented on a change in pull request #1422:
URL: https://github.com/apache/cassandra/pull/1422#discussion_r828814336
##########
File path:
test/unit/org/apache/cassandra/cql3/validation/operations/AlterTest.java
##########
@@ -821,8 +821,7 @@ public void testAlterTableAddColWithIfNotExists() throws
Throwable
public void testAlterTableAddExistingColumnWithoutIfExists()
{
createTable("CREATE TABLE %s (a int, b int, PRIMARY KEY (a, b)); ");
- assertAlterTableThrowsException(InvalidRequestException.class,
- String.format("Column with name '%s'
already exists", "a"), "ALTER TABLE IF EXISTS %s ADD a int");
+ assertAlterTableThrowsException(InvalidRequestException.class,
String.format("Column with name '%s' already exists", "a"), "ALTER TABLE IF
EXISTS %s ADD a int");
Review comment:
I was referring to the fact we try to avoid long lines. This would
probably end up in 3 lines, one for each arg, and the 3 args aligned. Look
[here](https://github.com/apache/cassandra/blob/46f617900d1f2061bff38440036b420216634816/test/unit/org/apache/cassandra/cql3/validation/operations/AlterTest.java#L165)
i.e. or the C* code style
It's a nit, but just to let you know this is how we format things.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
