belliottsmith commented on PR #5: URL: https://github.com/apache/cassandra-accord/pull/5#issuecomment-1192977771
> One thing that should be cleaned up by the time the partial replication patch is merged is the number of TODO (now) comments that were added here. I think we need e.g. `TODO (soon)`. I've triaged and completed the most important `TODO (now)`, leaving ones I don't have time for but still want to get done ahead of many of the other `TODO`. I'll clean up either way, at least. > Finally, I know this is easier said than done, but keeping refactors and functional changes in separate commits would really help speed up review by limiting the scope of each sub-review. I realize they usually happen during implementation, but something for the wish list at least :) Yeah, sorry. Time pressure leads to corner-cutting here. It's time consuming to rebase and separate things, but perhaps a false economy if it steals your time. I'll have a look over the next patch sets to see what I can do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
