adelapena commented on code in PR #1748:
URL: https://github.com/apache/cassandra/pull/1748#discussion_r929155508
##########
src/java/org/apache/cassandra/service/GCInspector.java:
##########
@@ -55,7 +55,7 @@ public class GCInspector implements NotificationListener,
GCInspectorMXBean
public static final String MBEAN_NAME =
"org.apache.cassandra.service:type=GCInspector";
private static final Logger logger =
LoggerFactory.getLogger(GCInspector.class);
private volatile long gcLogThreshholdInMs =
DatabaseDescriptor.getGCLogThreshold();
- private volatile long gcWarnThreasholdInMs =
DatabaseDescriptor.getGCWarnThreshold();
+ private volatile long gcWarnThresholdInMs =
DatabaseDescriptor.getGCWarnThreshold();
Review Comment:
Setting them as `volatile` in `Config` should work, but I was thinking on
removing the local copies on `GCInspector`, [this
way](https://github.com/adelapena/cassandra/commit/cb1534ca0242c93277ea01511459604d03c86c9c),
as we did in CASSANDRA-17735. wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
