dcapwell commented on code in PR #1750:
URL: https://github.com/apache/cassandra/pull/1750#discussion_r930296439
##########
src/java/org/apache/cassandra/service/StorageService.java:
##########
@@ -1776,11 +1776,18 @@ public Collection<InetAddressAndPort>
prepareForBootstrap(long schemaTimeoutMill
{
if (!isReplacingSameAddress())
{
+ // Historically BROADCAST_INTERVAL was used, but this is
unrelated to ring_delay, so using it to know
+ // how long to sleep only works with the default settings
(ring_delay=30s, broadcast=60s). For users
+ // who are aware of this relationship, this coupling should
not be broken, but for most users this
+ // relationship isn't known and instead we should rely on the
ring_delay.
+ // See CASSANDRA-17776
+ long sleepDelayMillis =
Math.max(LoadBroadcaster.BROADCAST_INTERVAL, ringTimeoutMillis * 2);
try
{
// Sleep additionally to make sure that the server
actually is not alive
// and giving it more time to gossip if alive.
- Thread.sleep(LoadBroadcaster.BROADCAST_INTERVAL);
+ logger.info("Sleeping for {}ms waiting to make sure no new
updates happen for {}", sleepDelayMillis,
DatabaseDescriptor.getReplaceAddress());
Review Comment:
went with `gossip updates`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
