ekaterinadimitrova2 commented on code in PR #1758: URL: https://github.com/apache/cassandra/pull/1758#discussion_r931537598
########## conf/cassandra.yaml: ########## @@ -992,6 +992,8 @@ compaction_throughput: 64MiB/s # are completely written, and used in place of the prior sstables for # any range that has been written. This helps to smoothly transfer reads # between the sstables, reducing page cache churn and keeping hot rows hot +# Set sstable_preemptive_open_interval to null for disabled which is equivalent to the sstable_preemptive_open_interval_in_mb +# being negative Review Comment: Oh, we actually have guardrails of the newly introduced configuration types and they use disabled = null, as they are enabled per guardrail, the big guardrails feature flag was removed and they are individually enabled. Adding an enable flag for every guardrail will be a pain so I think we should stay with the null option, at least for those. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
