maedhroz commented on code in PR #1751:
URL: https://github.com/apache/cassandra/pull/1751#discussion_r932563089


##########
src/java/org/apache/cassandra/db/compaction/CompactionStrategyManager.java:
##########
@@ -141,6 +146,8 @@ should update the compaction strategy in maybeReload() due 
to an ALTER.
     private volatile long maxSSTableSizeBytes;
     private volatile String name;
 
+    public static int TWCS_BUCKET_COUNT_MAX = 30;

Review Comment:
   The only easy improvement I can think of is to raise it to something that 
won't truncate w/ a slight misconfiguration. 128 maybe? Failing the JMX call 
because there are too many buckets seems like a bad option...
   
   @krummas Thoughts?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to