ekaterinadimitrova2 commented on code in PR #1758:
URL: https://github.com/apache/cassandra/pull/1758#discussion_r932665394
##########
src/java/org/apache/cassandra/config/YamlConfigurationLoader.java:
##########
@@ -363,10 +365,12 @@ else if (result.getAnnotation(Deprecated.class) != null)
return new ForwardingProperty(result.getName(), result)
{
+ boolean allowsNull = result.getAnnotation(Nullable.class) !=
null;
+
@Override
public void set(Object object, Object value) throws Exception
{
- if (value == null && get(object) != null)
+ if (value == null && get(object) != null && !allowsNull)
Review Comment:
I thought about that yesterday but my concern is that there are too many of
those and they are not only from the new types and not only new ones...
Maybe we can open a follow up ticket only on trunk as an improvement? And
add more testing, etc... I am afraid we are getting into another rabbit hole.
Also, it is good if we can keep this case as an exception and not make
people think that it is a good practice. Why? Because if they start adding
other default values and do not test properly that the null value is handled
(and I am sure someone will do that) this can be reaaaally bad. What do you
think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
