Claudenw commented on code in PR #1759:
URL: https://github.com/apache/cassandra/pull/1759#discussion_r936290165
##########
test/unit/org/apache/cassandra/config/YamlConfigurationLoaderTest.java:
##########
@@ -311,6 +311,10 @@ public void converters()
assertThatThrownBy(() ->
from("stream_throughput_outbound_megabits_per_sec",
-2).stream_throughput_outbound.toMegabitsPerSecondAsInt())
.hasRootCauseInstanceOf(IllegalArgumentException.class)
.hasRootCauseMessage("Invalid data rate: value must be non-negative");
+
+ // NEGATIVE_DATA_STORAGE_INT
+ assertThat(from("sstable_preemptive_open_interval_in_mb",
"1").sstable_preemptive_open_interval.toMebibytes()).isEqualTo(1);
+ assertThat(from("sstable_preemptive_open_interval_in_mb",
-2).sstable_preemptive_open_interval).isNull();
}
Review Comment:
Just that it sits on the boundary and the test would make it clear that 0
sets bound of 0 while -1 sets no bound, and 1 shows that the bound actually
gets set to the proper value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
