dcapwell commented on code in PR #8:
URL: https://github.com/apache/cassandra-accord/pull/8#discussion_r936933244
##########
accord-maelstrom/src/main/java/accord/maelstrom/Cluster.java:
##########
@@ -163,15 +163,17 @@ public boolean processPending()
}
err.println(clock++ + " RECV " + deliver);
err.flush();
- if (deliver.body.in_reply_to > Body.SENTINEL_MSG_ID)
+ Object body = ((Wrapper)deliver.body).body;
+ //TODO : REVIEW : Don't know the point of
deliver.body.in_reply_to > Body.SENTINEL_MSG_ID, but without it
InformOfTxnReply fails
+ if (deliver.body.in_reply_to > Body.SENTINEL_MSG_ID ||
body instanceof Reply)
Review Comment:
Don't know the point of deliver.body.in_reply_to > Body.SENTINEL_MSG_ID, but
without it InformOfTxnReply fails
##########
accord-maelstrom/src/main/java/accord/maelstrom/Cluster.java:
##########
@@ -163,15 +163,17 @@ public boolean processPending()
}
err.println(clock++ + " RECV " + deliver);
err.flush();
- if (deliver.body.in_reply_to > Body.SENTINEL_MSG_ID)
+ Object body = ((Wrapper)deliver.body).body;
+ //TODO : REVIEW : Don't know the point of
deliver.body.in_reply_to > Body.SENTINEL_MSG_ID, but without it
InformOfTxnReply fails
+ if (deliver.body.in_reply_to > Body.SENTINEL_MSG_ID ||
body instanceof Reply)
Review Comment:
Don't know the point of `deliver.body.in_reply_to > Body.SENTINEL_MSG_ID`,
but without it InformOfTxnReply fails
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
