dcapwell commented on code in PR #6:
URL: https://github.com/apache/cassandra-accord/pull/6#discussion_r937241969
##########
accord-core/src/main/java/accord/api/Key.java:
##########
@@ -3,10 +3,7 @@
/**
* A routing key for determining which shards are involved in a transaction
*/
-public interface Key<K extends Key<K>> extends Comparable<K>
+public interface Key<K extends Key<K>> extends RoutingKey<K>
{
- /**
- * Returns a hash code of a key to support accord internal sharding. Hash
values for equal keys must be equal.
- */
- int keyHash();
+ Key toRoutingKey();
Review Comment:
no confusion at all! I personally rely on GH comments to make sure nothing
gets dropped, so when GH starts to hide things I like to re-comment just to
make sure it doesn't get lost.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
