yifan-c commented on code in PR #1770:
URL: https://github.com/apache/cassandra/pull/1770#discussion_r939070417
##########
src/java/org/apache/cassandra/db/commitlog/CommitLogSegmentManagerCDC.java:
##########
@@ -219,6 +224,8 @@ private void throwIfForbidden(Mutation mutation,
CommitLogSegment segment) throw
/**
* On segment creation, flag whether the segment should accept CDC
mutations or not based on the total currently
* allocated unflushed CDC segments and the contents of cdc_raw
+ *
+ * Synchronized on this
Review Comment:
The method is an abstract one defined in the base class though.
Alternatively, we can add `synchronized` to the method signature. Synchronize
within a synchronized block should add trivial impact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
