dcapwell commented on code in PR #1611:
URL: https://github.com/apache/cassandra/pull/1611#discussion_r940406567
##########
src/java/org/apache/cassandra/config/Config.java:
##########
@@ -134,6 +134,8 @@
public volatile Integer repair_session_max_tree_depth = null;
public volatile Integer repair_session_space_in_mb = null;
+ public volatile long repair_message_timeout_in_ms =
TimeUnit.MILLISECONDS.convert(1, TimeUnit.MINUTES);
Review Comment:
when this gets added to 4.1 should this also be migrated? Feels weird to
migrate as its new... @ekaterinadimitrova2 thoughts? Should we just add the
needed data types so we can do `DurationSpec repair_message_timeout =
DurationSpec.ofMinutes(1);`?
##########
src/java/org/apache/cassandra/repair/messages/RepairMessage.java:
##########
@@ -26,10 +42,57 @@
*/
public abstract class RepairMessage
{
+ private static final CassandraVersion SUPPORTS_TIMEOUTS = new
CassandraVersion("4.0.4-SNAPSHOT"); // todo: should be 4.0.5 (4.0.4 is about to
be cut)
Review Comment:
should be 4.0.6 at this point: 4.0.5 released on July 18
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
