ekaterinadimitrova2 commented on code in PR #1684:
URL: https://github.com/apache/cassandra/pull/1684#discussion_r941736954


##########
conf/cassandra.yaml:
##########
@@ -1752,6 +1752,17 @@ drop_compact_storage_enabled: false
 # write_consistency_levels_warned: []
 # write_consistency_levels_disallowed: []
 #
+# Guardrail to warn or fail when writing column values larger than threshold.
+# This guardrail is only applied to the values of regular columns because both 
the serialized partitions keys and the
+# values of the components of the clustering key already have a fixed, 
relatively small size limit of 65535 bytes, which

Review Comment:
   So I was not sure immediately where that value came from - 65535 bytes. 
   So I found this in the QueryProcessor - 
   ```
   // check that key can be handled by FBUtilities.writeShortByteArray
           if (key.remaining() > FBUtilities.MAX_UNSIGNED_SHORT)
   ```
   The comment seems outdated as there is no `FBUtilities.writeShortByteArray` 
now. Shall we use the opportunity to clear this a bit? WDYT? I mean the whole 
explanation where this number comes from



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to