dcapwell commented on PR #6: URL: https://github.com/apache/cassandra-accord/pull/6#issuecomment-1212596386
> Benchmark[name=merge Is this with `with`? or a new version of `merge`? > We do have to decide if we simply discard the algorithmically "better" approach I am a huge fan of "less is more", so if we can remove code and be in the same position I am all for it. > or perhaps include it with a note that it has not been reviewed these things have a way to coming back to bite in the future, so if we keep it needs to go through review + testing. > I'm not sure of a better way to park this kind of code. A branch will get lost, but perhaps that's fine. There is branch and gist... but the ability to "discovery" I find is always a pain... If I need to find code I discard 6m path I have no idea how to find... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
