maedhroz commented on code in PR #1796:
URL: https://github.com/apache/cassandra/pull/1796#discussion_r950488236
##########
src/java/org/apache/cassandra/service/TruncateResponseHandler.java:
##########
@@ -61,24 +63,34 @@ public TruncateResponseHandler(int responseCount)
public void get() throws TimeoutException
{
long timeoutNanos = getTruncateRpcTimeout(NANOSECONDS) - (nanoTime() -
start);
- boolean completedInTime;
+ boolean signaled;
try
{
- completedInTime = condition.await(timeoutNanos, NANOSECONDS); //
TODO truncate needs a much longer timeout
+ signaled = condition.await(timeoutNanos, NANOSECONDS); // TODO
truncate needs a much longer timeout
}
catch (InterruptedException e)
{
throw new UncheckedInterruptedException(e);
}
- if (!completedInTime)
- {
+ if (!signaled)
throw new TimeoutException("Truncate timed out - received only " +
responses.get() + " responses");
- }
- if (truncateFailingReplica != null)
+ if (!failureReasonByEndpoint.isEmpty())
{
- throw new TruncateException("Truncate failed on replica " +
truncateFailingReplica);
+ // clone to make sure no race condition happens
+ Map<InetAddressAndPort, RequestFailureReason>
failureReasonByEndpoint = new HashMap<>(this.failureReasonByEndpoint);
+ int size = failureReasonByEndpoint.size();
+ long timeouts =
failureReasonByEndpoint.values().stream().filter(RequestFailureReason.TIMEOUT::equals).count();
+ long nonTimeout = size - timeouts;
+ if (nonTimeout <= timeouts)
+ throw new TimeoutException("Truncate timed out - received only
" + responses.get() + " responses");
Review Comment:
If you pointed a gun to my head rn, for all three cases
(read/write/truncate), I would just...
1.) throw a timeout if all the failure reasons in the map are TIMEOUT
2.) show the user the failure map by endpoint attached to a real error
otherwise
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
