frankgh commented on code in PR #36:
URL: https://github.com/apache/cassandra-sidecar/pull/36#discussion_r958938825
##########
src/test/java/org/apache/cassandra/sidecar/routes/StreamSSTableComponentHandlerTest.java:
##########
@@ -315,9 +316,10 @@ void testSuffixRangeExceeds(VertxTestContext context)
.send(context.succeeding(response -> context.verify(() ->
{
assertThat(response.statusCode()).isEqualTo(OK.code());
+ AbstractStringAssert<?> as =
assertThat(response.getHeader(HttpHeaderNames.CONTENT_LENGTH.toString()))
- .isEqualTo("4")
- .describedAs("Server should shrink the range to the
file length");
+ .describedAs("Server should shrink the range to the
file length")
Review Comment:
`describeAs` is annotated with `org.assertj.core.util.CheckReturnValue`
which is documented as `Findbugs handles any annotation with name
"CheckReturnValue" in return value check.` . This was failing the build with
warning `RV_RETURN_VALUE_IGNORED: Method ignores return value`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
