jacek-lewandowski commented on code in PR #1804:
URL: https://github.com/apache/cassandra/pull/1804#discussion_r960528059
##########
src/java/org/apache/cassandra/schema/SchemaUpdateHandler.java:
##########
@@ -63,14 +64,15 @@
* refreshed, the callbacks provided in the factory method are executed,
and the updated schema version is announced.
*
* @param local whether we should reset with locally stored schema or
fetch the schema from other nodes
- * @return transformation result
*/
- SchemaTransformationResult reset(boolean local);
+ void reset(boolean local);
/**
* Clears the locally stored schema entirely. After this operation the
schema is equal to {@link DistributedSchema#EMPTY}.
* The method does not execute any callback. It is indended to
reinitialize the schema later using the method
* {@link #reset(boolean)}.
+ *
+ * @return
Review Comment:
ok, and btw. I suppose the more adequate names for those methods now would
be reset -> sync, clear -> refresh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
