michaelsembwever commented on PR #1799: URL: https://github.com/apache/cassandra/pull/1799#issuecomment-1235545964
> Say more here? (Not that I'm re-opening this can of worms, I'm fine either way. Want to learn here). > Is the concern that it'll signal some larger commitment that'll be off-putting for new contributors and we'd rather defer it to later in their contribution process? Or is the ICLA only needed when one becomes a committer on a project … It's only required by large contributions (and when becoming a committer). It does not apply to reader we are primarily targeting here. The onus is on the committer reviewing to catch any such need. > the assignment of copyright and legal usage is implicit with a PR someone opens? Correct. Our license states it. Significant contributions that add new files, we want to ask the contributor to ensure they have added to license file to the files themselves (which creates the implicit acknowledgement). This is one of the reasons we have the rat check in the build/test process. We probably need to be better at ensuring the committers when reviewing know this. But this PR template text is not the place for that, IMHO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
