iamaleksey commented on code in PR #1831:
URL: https://github.com/apache/cassandra/pull/1831#discussion_r963900543
##########
src/java/org/apache/cassandra/cql3/statements/schema/TableAttributes.java:
##########
@@ -98,6 +98,9 @@ public static Set<String> allKeywords()
private TableParams build(TableParams.Builder builder)
{
+ if (hasOption(Option.ALLOW_AUTO_SNAPSHOT))
+
builder.allowAutoSnapshot(getBoolean(Option.ALLOW_AUTO_SNAPSHOT.toString(),
false));
Review Comment:
I don't think this default value is correct. But more importantly, we know
the option is present, so we shouldn't even be passing the default. Need to add
a method that doesn't take a default value. And also do the same for `cdc`
while here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
