ekaterinadimitrova2 commented on code in PR #1850:
URL: https://github.com/apache/cassandra/pull/1850#discussion_r966459013
##########
src/java/org/apache/cassandra/schema/MigrationManager.java:
##########
@@ -260,18 +260,7 @@ public static void resetLocalSchema()
Schema.instance.clear();
- Set<InetAddressAndPort> liveEndpoints =
Gossiper.instance.getLiveMembers();
- liveEndpoints.remove(FBUtilities.getBroadcastAddressAndPort());
-
- // force migration if there are nodes around
- for (InetAddressAndPort node : liveEndpoints)
- {
- EndpointState state =
Gossiper.instance.getEndpointStateForEndpoint(node);
- Future<Void> pull =
MigrationCoordinator.instance.reportEndpointVersion(node, state);
- if (pull != null)
- FBUtilities.waitOnFuture(pull);
- }
-
+ MigrationCoordinator.instance.reset();
Review Comment:
So reset in the coordinator was not used up to now... I am wondering why. It
had also different behavior but no comment/Javadoc to confirm the goal. Not
sure whether it is ok to change the behavior of public method in a patch
release, @adelapena, @bdeggleston, any thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
