adelapena commented on code in PR #1850:
URL: https://github.com/apache/cassandra/pull/1850#discussion_r966830380
##########
src/java/org/apache/cassandra/config/CassandraRelevantProperties.java:
##########
@@ -194,7 +194,17 @@
IS_DISABLED_MBEAN_REGISTRATION("org.apache.cassandra.disable_mbean_registration"),
/** what class to use for mbean registeration */
- MBEAN_REGISTRATION_CLASS("org.apache.cassandra.mbean_registration_class");
+ MBEAN_REGISTRATION_CLASS("org.apache.cassandra.mbean_registration_class"),
+
+ MIGRATION_DELAY("cassandra.migration_delay_ms", "60000"),
+ /** Defines how often schema definitions are pulled from the other nodes */
+ SCHEMA_PULL_INTERVAL_MS("cassandra.schema_pull_interval_ms", "60000"),
+ /**
+ * Minimum delay after a failed pull request before it is reattempted. It
prevents reattempting failed requests
+ * immediately as it is high chance they will fail anyway. It is better to
wait a bit instead of flooding logs
+ * and wasting resources.
+ * */
+ SCHEMA_PULL_BACKOFF_DELAY_MS("cassandra.schema_pull_backoff_delay_ma",
"3000");
Review Comment:
```suggestion
SCHEMA_PULL_BACKOFF_DELAY_MS("cassandra.schema_pull_backoff_delay_ms",
"3000");
```
##########
src/java/org/apache/cassandra/config/CassandraRelevantProperties.java:
##########
@@ -194,7 +194,17 @@
IS_DISABLED_MBEAN_REGISTRATION("org.apache.cassandra.disable_mbean_registration"),
/** what class to use for mbean registeration */
- MBEAN_REGISTRATION_CLASS("org.apache.cassandra.mbean_registration_class");
+ MBEAN_REGISTRATION_CLASS("org.apache.cassandra.mbean_registration_class"),
+
+ MIGRATION_DELAY("cassandra.migration_delay_ms", "60000"),
+ /** Defines how often schema definitions are pulled from the other nodes */
+ SCHEMA_PULL_INTERVAL_MS("cassandra.schema_pull_interval_ms", "60000"),
+ /**
+ * Minimum delay after a failed pull request before it is reattempted. It
prevents reattempting failed requests
+ * immediately as it is high chance they will fail anyway. It is better to
wait a bit instead of flooding logs
+ * and wasting resources.
+ * */
Review Comment:
```suggestion
*/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]