adelapena commented on code in PR #1723:
URL: https://github.com/apache/cassandra/pull/1723#discussion_r972214152
##########
.circleci/config-2_1.yml:
##########
@@ -49,6 +49,7 @@ default_env_vars: &default_env_vars
# REPEATED_UTEST_TARGET: test-jvm-dtest-some
# REPEATED_UTEST_TARGET: test-cdc
# REPEATED_UTEST_TARGET: test-compression
+ # REPEATED_UTEST_TARGET: test-trie
Review Comment:
The new job is nice to have, thanks. Just a detail, we should update the
patch file headers (`config-2_1.yml.mid_res.patch` and
`config-2_1.yml.high_res.patch`) so the generation script doesn't produce
warnings about hunks:
```
Hunk #1 succeeded at 106 (offset 1 line).
Hunk #2 succeeded at 121 (offset 1 line).
Hunk #3 succeeded at 163 (offset 1 line).
Hunk #4 succeeded at 936 (offset 39 lines).
Hunk #5 succeeded at 950 (offset 39 lines).
...
```
This can be done by running this:
```
cd .circleci
# apply old patches (with hunk messages)
patch -o config-2_1.yml.MIDRES config-2_1.yml config-2_1.yml.mid_res.patch
patch -o config-2_1.yml.HIGHRES config-2_1.yml config-2_1.yml.high_res.patch
# generate new patches
diff -u config-2_1.yml config-2_1.yml.HIGHRES > config-2_1.yml.high_res.patch
diff -u config-2_1.yml config-2_1.yml.MIDRES > config-2_1.yml.mid_res.patch
# verify that the new patches generate the same files and cleanup
./generate.sh -a
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
