maedhroz commented on code in PR #1855:
URL: https://github.com/apache/cassandra/pull/1855#discussion_r972409542


##########
test/unit/org/apache/cassandra/io/sstable/SSTableReaderTest.java:
##########
@@ -247,6 +253,23 @@ public void testReadRateTracking()
 
         Util.getAll(Util.cmd(store, key).includeRow("0").build());
         assertEquals(2, sstable.getReadMeter().count());
+
+        // With persistence enabled, we should be able to retrieve the state 
of the meter.
+        sstable.maybePersistSSTableReadMeter();
+
+        UntypedResultSet meter = 
SystemKeyspace.readSSTableActivity(store.keyspace.getName(), store.name, 
sstable.descriptor.id);
+        // So this is the only issue atm; seems like it's empty

Review Comment:
   nit: What does this comment mean? Looks like the assertion verifies that 
is't _not_ empty?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to