blerer commented on code in PR #1878: URL: https://github.com/apache/cassandra/pull/1878#discussion_r981375482
########## test/unit/org/apache/cassandra/cql3/functions/MathFctsTest.java: ########## @@ -0,0 +1,231 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.cql3.functions; + +import java.nio.ByteBuffer; +import java.util.Collections; +import java.util.List; + +import org.junit.Test; + +import org.apache.cassandra.db.marshal.CounterColumnType; +import org.apache.cassandra.db.marshal.DoubleType; +import org.apache.cassandra.db.marshal.FloatType; +import org.apache.cassandra.db.marshal.IntegerType; +import org.apache.cassandra.db.marshal.ByteType; +import org.apache.cassandra.db.marshal.DecimalType; +import org.apache.cassandra.db.marshal.Int32Type; +import org.apache.cassandra.db.marshal.LongType; +import org.apache.cassandra.db.marshal.ShortType; +import org.apache.cassandra.transport.ProtocolVersion; +import org.apache.cassandra.utils.ByteBufferUtil; + +import static org.junit.Assert.assertEquals; + +public class MathFctsTest Review Comment: It does not seems to me that we really test properly the functions. The set of input we use is pretty limited and the test inputs are different with different types assuming that the type is not an important part of the testing. I would make sense to test each types with the same input. It looks like it should be possible to create some test utility methods that take a type, an input and an expected output to validate a function. ########## src/java/org/apache/cassandra/cql3/functions/MathFcts.java: ########## @@ -0,0 +1,140 @@ + /* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + + package org.apache.cassandra.cql3.functions; + + import java.nio.ByteBuffer; + import java.util.Collection; + import java.util.List; + import java.util.stream.Collectors; + + import com.google.common.collect.ImmutableList; + import org.slf4j.Logger; + import org.slf4j.LoggerFactory; + + import org.apache.cassandra.db.marshal.*; + import org.apache.cassandra.transport.ProtocolVersion; + + public class MathFcts Review Comment: Nits: As the class contains only static methods it should be final and the constructor should be private. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
