maedhroz commented on code in PR #1949:
URL: https://github.com/apache/cassandra/pull/1949#discussion_r1005193092
##########
src/java/org/apache/cassandra/service/StorageService.java:
##########
@@ -2074,7 +2074,6 @@ public void onFailure(Throwable e)
}
logger.error(message, e);
progressSupport.progress("bootstrap", new
ProgressEvent(ProgressEventType.ERROR, 1, 1, message));
- progressSupport.progress("bootstrap", new
ProgressEvent(ProgressEventType.COMPLETE, 1, 1, "Resume bootstrap complete"));
Review Comment:
The thing that worries me about this is that it will hang older versions of
`nodetool` when an error occurs. They will be waiting for a `COMPLETE` that
will never arrive after printing the error message. The fact that we're
changing the behavior of `nodetool` itself on error in this Jira probably means
that we only need to patch trunk, but it's probably not worth it to remove the
`COMPLETE` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
