ekaterinadimitrova2 commented on PR #1953: URL: https://github.com/apache/cassandra/pull/1953#issuecomment-1292868745
You are almost there. The patches are not created correctly. You use the recipe I mentioned on the other PR which covers the case when the patches are still the same, applicable, just moving a few lines and unneeded warnings popping up. In your case when you add the new jobs things shift and you still get wrong resources assigned to your jobs. You will need to modify cassandra-2_1.yml so that it can generate correct MIDRES and HIGHRES files and then create a patch. The way we do patches for code. You do the changes, you get a patch from the diff. This is explained in the readme and I explained in the very first patch. We always need to check the final results in the MIDRES and HIGHRES files to ensure resources didn't shift for some reason. Now in this case I can still see wrong resources. This is what I mentioned in the previous PR review, it is still applicable: `Actually how were MIDRES and HIGHRES created? They use the same j8_par_executor as the other dtests but I see different resources in Midres - medium and 25, when j8_dtests gets large and 50?` Your resources are still wrong because you probably used the recipe for recreating patches which cover the case when resources are correctly assigned. So looking into the current MIDRES file for cassandra 3.11 you need to end up with LARGE and 50 for running all tests(https://github.com/apache/cassandra/blob/cassandra-3.11/.circleci/config.yml.MIDRES#L1728-L1734) and LARGE and 25 for running tests in a loop (https://github.com/apache/cassandra/blob/cassandra-3.11/.circleci/config.yml.MIDRES#L1057-L1063) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
