josh-mckenzie commented on code in PR #185: URL: https://github.com/apache/cassandra-website/pull/185#discussion_r1006801469
########## site-content/source/modules/ROOT/pages/blog/Apache-Cassandra-4.1-Features-Guardrails-Framework.adoc: ########## @@ -70,7 +70,7 @@ Warnings : Guardrail tables violated: Creating table t6, current number of tables 6 exceeds warning threshold of 5. ``` -However, if the hard limit is reached, the user operation will be aborted with a `GuardrailViolatedException`, preventing the potentially harmful operation from happening. Continuing with the previous example, if we have a hard limit of ten tables (`tables_warn_threshold: 10`) and we try to create an eleventh table, we will see an error and the eleventh table won’t be created: +However, if the hard limit is reached, the user operation will be aborted with a `GuardrailViolatedException`, preventing the potentially harmful operation from happening. Continuing with the previous example, if we have a hard limit of ten tables (`tables_fail_threshold: 10`) and we try to create an eleventh table, we will see an error and the eleventh table won’t be created: Review Comment: Do we regularly sneak things in to PR's for website changes? For the record: definitely not against this. Just want to double check this isn't accidentally flying under the radar here and colliding with other work in flight and/or accidentally pulled over from a larger change. ########## site-content/source/modules/ROOT/pages/download.adoc: ########## @@ -18,14 +18,14 @@ [discrete] ==== Download the latest Apache Cassandra 4.0 GA release: [discrete] -====== Released on 2022-08-25 +====== Released on 2022-10-23 Review Comment: How do we normally update versions on the site? Is this something we just do adhoc when we realize they're stale, or perhaps something we can integrate into our release manager pipeline and collab w/Mick / release managers on? ########## site-content/source/modules/ROOT/pages/events.adoc: ########## @@ -0,0 +1,277 @@ += Events +:page-layout: events +:page-role: events + +//// +NOTES FOR CONTENT CREATORS +- To add a new event card, copy and paste markup for one card below. Copy from '//start' to the next '//end' +- Replace event card fields: title, date, image, short text and external link. +//// + +//start card +[openblock,card shadow relative test] +---- +[openblock,card-header] +------ +[discrete] +=== Cassandra Summit 2023 +[discrete] +==== March 13-14, 2023 +------ +[openblock,card-content] +------ +image:events/c_summit_logo.png[Cassandra Summit logo] + +Cassandra Summit is back! Let's meet in San Jose, California, to celebrate what we built together and share what's coming next. + +[openblock,card-btn card-btn--events] +-------- +[.btn.btn--alt] +https://events.linuxfoundation.org/cassandra-summit/[Go to event,window=_blank] Review Comment: When we link to external non-ASF hosted sites, is there any need for a notification that you're leaving the ASF space and going to a particular vendor or other foundation's properties / sites? Genuinely asking here as I don't know and want to make sure we grease the skids on this as much as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
