bdeggleston commented on code in PR #1948:
URL: https://github.com/apache/cassandra/pull/1948#discussion_r1009847239
##########
src/java/org/apache/cassandra/service/accord/AccordKeyspace.java:
##########
@@ -115,12 +115,12 @@
private static final Logger logger =
LoggerFactory.getLogger(AccordKeyspace.class);
public static final String COMMANDS = "commands";
- public static final String COMMAND_SERIES = "command_series";
public static final String COMMANDS_FOR_KEY = "commands_for_key";
private static final String TIMESTAMP_TUPLE = "tuple<bigint, bigint, int,
bigint>";
private static final TupleType TIMESTAMP_TYPE = new
TupleType(Lists.newArrayList(LongType.instance, LongType.instance,
Int32Type.instance, LongType.instance));
private static final String KEY_TUPLE = "tuple<uuid, blob>";
+ private static final int CURRENT_VERSION = 1;
Review Comment:
the version used in IVersionedSerializer is intended to be the messaging
service version, to support serializer changes in mixed mode clusters, so if
we're going to be passing this directly into serializers, it does need to map
to a current messaging version. That said, decoupling accord serializers from
the messaging service _is_ a good idea. I'm already doing this in
AccordPartialCommand.PartialCommandSerializer.Version. Why not promote that
enum to AccordSerializerVersion and use it instead? That way you can still pass
valid message versions into downstream serializers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
