belliottsmith commented on code in PR #7: URL: https://github.com/apache/cassandra-accord/pull/7#discussion_r1011719745
########## accord-core/src/main/java/accord/impl/SimpleProgressLog.java: ########## @@ -77,8 +61,13 @@ import static accord.impl.SimpleProgressLog.Progress.NoProgress; import static accord.impl.SimpleProgressLog.Progress.NoneExpected; import static accord.impl.SimpleProgressLog.Progress.advance; -import static accord.local.Status.Executed; +import static accord.local.PreLoadContext.contextFor; +import static accord.local.Status.Durability.Durable; +import static accord.local.Status.ReplicationPhase.Apply; +import static accord.local.Status.ReplicationPhase.None; +import static accord.local.Status.PreApplied; +// TODO: consider propagating invalidations in the same way as we do applied public class SimpleProgressLog implements Runnable, ProgressLog.Factory Review Comment: From the POV of the protocol it's more of a log we provide progress information to, which is then decides whether to act upon. But we can call it something else if you have a snappy name. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
