dcapwell commented on code in PR #1965:
URL: https://github.com/apache/cassandra/pull/1965#discussion_r1012107377
##########
test/distributed/org/apache/cassandra/distributed/test/ring/BootstrapTest.java:
##########
@@ -196,6 +197,12 @@ public void bootstrapUnspecifiedFailsOnResumeTest() throws
Throwable
bootstrap()),
newInstance.config().num());
}
+ catch (AssumptionViolatedException ave)
+ {
+ // We get an AssumptionViolatedException if we're in a test job
configured w/vnodes
+ if (ave.getMessage().contains("vnode is requested but not
supported"))
Review Comment:
remove this check, the type is very explicit "junit ignore this test", you
trying to ignore that isn't good and will be brittle.
Also, add `throw ave` so it actually is skipped and not passing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
