belliottsmith commented on code in PR #7:
URL: https://github.com/apache/cassandra-accord/pull/7#discussion_r1014300874
##########
accord-core/src/main/java/accord/primitives/KeyRange.java:
##########
@@ -310,19 +285,19 @@ public KeyRange intersection(KeyRange that)
if (this.compareIntersecting(that) != 0)
return null;
- Key start = this.start.compareTo(that.start) > 0 ? this.start :
that.start;
- Key end = this.end.compareTo(that.end) < 0 ? this.end : that.end;
+ RoutingKey start = this.start.compareTo(that.start) > 0 ? this.start :
that.start;
+ RoutingKey end = this.end.compareTo(that.end) < 0 ? this.end :
that.end;
return subRange(start, end);
}
/**
* returns the index of the first key larger than what's covered by this
range
*/
- public int nextHigherKeyIndex(Keys keys, int from)
+ public int nextHigherKeyIndex(AbstractKeys<?, ?> keys, int from)
{
- int i = SortedArrays.exponentialSearch(keys.keys, from, keys.size(),
this, KeyRange::compareTo, FLOOR);
+ int i = SortedArrays.exponentialSearch(keys.keys, from, keys.size(),
this, KeyRange::compareTo, Search.FLOOR);
Review Comment:
Would prefer to leave this until `routables` as I'll no doubt miss it in
rebase anyway
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
