belliottsmith commented on PR #7: URL: https://github.com/apache/cassandra-accord/pull/7#issuecomment-1303963293
I've just introduced another enum I've called `SaveStatus` that is equivalent to `Status` except it correctly tracks `Status.Known` (i.e. remembers that we have `PreAccepted` in `Accepted` and `AcceptedInvalidate` states). I think a separate enum is warranted here, as `Status` is the more ergonomic one for most use cases, and so I have for now used `SaveStatus` as a kind of hidden implementation detail. I'm inclined to stop massaging this here, but there's an argument to be made that `CheckShards` etc. should work on `SaveStatus` rather than `Status`. But, it is not required for correctness. Perhaps something to consider later, as I think we need to draw a line in the sand at some point. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
