belliottsmith commented on code in PR #7:
URL: https://github.com/apache/cassandra-accord/pull/7#discussion_r1014510017
##########
accord-core/src/main/java/accord/impl/InMemoryCommand.java:
##########
@@ -218,21 +230,23 @@ public Status status()
}
@Override
- public void status(Status status)
+ public void setStatus(Status status)
{
this.status = status;
}
@Override
- public boolean isGloballyPersistent()
+ public Durability durability()
{
- return isGloballyPersistent;
+ if (status.hasBeen(PreApplied) && durability == NotDurable)
Review Comment:
We could do, but it's also an unnecessary additional step, since it's
defined by the `Status`. Not sure it's clearer to propagate it when updating
the status than to use the status as a lower bound when reading the
`durability`.
In part I assume that `status` will always be in memory, and in part I think
it is an easier place to impose the semantic. But I don't feel very strongly
about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
