tjake commented on PR #1954: URL: https://github.com/apache/cassandra/pull/1954#issuecomment-1336512942
Thanks for the great review. I reworked the code to avoid the whole limiting buffer/exception throwing. And I think addressed all the other issues you mentioned. > Why would caching a mutation at any given size be particularly bad for GC? Since you can end up making [Humongous allocations](https://docs.oracle.com/javase/10/gctuning/garbage-first-garbage-collector.htm#JSGCT-GUID-AC383806-7FA7-4698-8B92-4FD092B9F368) This threshold is based on the size of the heap but 1MB is a good default since that's the low end and covers 99% of Mutations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
