maedhroz commented on code in PR #1962: URL: https://github.com/apache/cassandra/pull/1962#discussion_r1040127624
########## test/distributed/org/apache/cassandra/distributed/test/accord/AccordTestBase.java: ########## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.distributed.test.accord; + +import java.io.IOException; +import java.util.Map; +import java.util.concurrent.Callable; +import java.util.concurrent.atomic.AtomicInteger; + +import com.google.common.base.Throwables; +import net.bytebuddy.ByteBuddy; +import net.bytebuddy.dynamic.loading.ClassLoadingStrategy; +import net.bytebuddy.implementation.MethodDelegation; +import net.bytebuddy.implementation.bind.annotation.SuperCall; +import net.bytebuddy.implementation.bind.annotation.This; +import org.assertj.core.api.Assertions; +import org.junit.AfterClass; +import org.junit.Before; +import org.junit.BeforeClass; +import org.slf4j.Logger; + +import accord.coordinate.Preempted; +import org.apache.cassandra.cql3.statements.ModificationStatement; +import org.apache.cassandra.cql3.statements.TransactionStatement; +import org.apache.cassandra.distributed.Cluster; +import org.apache.cassandra.distributed.api.ConsistencyLevel; +import org.apache.cassandra.distributed.api.Feature; +import org.apache.cassandra.distributed.api.SimpleQueryResult; +import org.apache.cassandra.distributed.test.TestBaseImpl; +import org.apache.cassandra.service.accord.AccordService; +import org.apache.cassandra.utils.FailingConsumer; + +import static net.bytebuddy.matcher.ElementMatchers.named; +import static org.junit.Assert.assertArrayEquals; + +public abstract class AccordTestBase extends TestBaseImpl +{ + protected static final AtomicInteger COUNTER = new AtomicInteger(0); + + protected static Cluster sharedCluster; + + protected String currentTable; + + @BeforeClass + public static void setupClass() throws IOException + { + sharedCluster = createCluster(); + } + + @AfterClass + public static void teardown() + { + if (sharedCluster != null) + sharedCluster.close(); + } + + @Before + public void setup() + { + currentTable = KEYSPACE + ".tbl" + COUNTER.getAndIncrement(); + } + + protected static void assertRow(Cluster cluster, String query, int k, int c, int v) + { + Object[][] result = cluster.coordinator(1).execute(query, ConsistencyLevel.QUORUM); + assertArrayEquals(new Object[]{new Object[] {k, c, v}}, result); + } + + protected void test(String tableDDL, FailingConsumer<Cluster> fn) throws Exception + { + sharedCluster.schemaChange(tableDDL); + sharedCluster.forEach(node -> node.runOnInstance(() -> AccordService.instance().createEpochFromConfigUnsafe())); + + // Evict commands from the cache immediately to expose problems loading from disk. + sharedCluster.forEach(node -> node.runOnInstance(() -> AccordService.instance().setCacheSize(0))); + + fn.accept(sharedCluster); + + // Reset any messaging filters. + sharedCluster.filters().reset(); + } + + protected void test(FailingConsumer<Cluster> fn) throws Exception + { + test("CREATE TABLE " + currentTable + " (k int, c int, v int, primary key (k, c))", fn); + } + + private static Cluster createCluster() throws IOException + { + // need to up the timeout else tests get flaky + // disable vnode for now, but should enable before trunk + return init(Cluster.build(2) + .withoutVNodes() + .withConfig(c -> c.with(Feature.NETWORK).set("write_request_timeout", "10s").set("transaction_timeout", "15s")) + .withInstanceInitializer(ByteBuddyHelper::install) + .start()); + } + + // TODO: Retry on preemption may become unnecessary after the Unified Log is integrated. + protected static SimpleQueryResult assertRowEqualsWithPreemptedRetry(Cluster cluster, Object[] row, String check, Object... boundValues) + { + SimpleQueryResult result = executeWithRetry(cluster, check, boundValues); + Assertions.assertThat(result.toObjectArrays()).isEqualTo(row == null ? new Object[0] : new Object[] { row }); + return result; + } + + protected static SimpleQueryResult executeWithRetry(Cluster cluster, String check, Object... boundValues) + { + try + { + return cluster.coordinator(1).executeWithResult(check, ConsistencyLevel.ANY, boundValues); + } + catch (Throwable t) + { + if (Throwables.getRootCause(t).toString().contains(Preempted.class.getName())) + return executeWithRetry(cluster, check, boundValues); + + throw t; + } + } + + public static class ByteBuddyHelper Review Comment: Yeah, that makes senes in the model where we install one rule per BB helper class. Fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
