maedhroz commented on code in PR #1962:
URL: https://github.com/apache/cassandra/pull/1962#discussion_r1041790210
##########
src/java/org/apache/cassandra/cql3/Operation.java:
##########
@@ -386,7 +416,7 @@ else if (!(receiver.type.isMultiCell()))
ColumnSpecification vr = new
ColumnSpecification(receiver.ksName,
receiver.cfName,
receiver.name,
-
SetType.getInstance(((MapType)receiver.type).getKeysType(), false));
+
SetType.getInstance(((MapType<?, ?>) receiver.type).getKeysType(), true));
Review Comment:
Short story: `testMultiCellMapSubtraction` will fail if you revert
Long story: If we create a frozen `SetType`, `vr` will eventually make it to
`testAssignment()` in `RowDataReference`, which will delegate to
`AbstractType#testAssignment()`. There, if we need to, we'll freeze the
receiver if necessary, but not do the opposite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
