dcapwell commented on code in PR #1962:
URL: https://github.com/apache/cassandra/pull/1962#discussion_r1038630486
##########
src/java/org/apache/cassandra/cql3/Operations.java:
##########
@@ -47,11 +49,34 @@ public final class Operations implements Iterable<Operation>
*/
private final List<Operation> staticOperations = new ArrayList<>();
+ private final List<ReferenceOperation> regularSubstitutions = new
ArrayList<>();
+ private final List<ReferenceOperation> staticSubstitutions = new
ArrayList<>();
Review Comment:
We need to know the ref columns in order to get the required columns read
~We should document why these are not included in `requiresRead`, the reason
is
`org.apache.cassandra.cql3.statements.ModificationStatement#readRequiredLists`
would then perform a read which we need to avoid.~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
