bdeggleston commented on code in PR #17:
URL: https://github.com/apache/cassandra-accord/pull/17#discussion_r1052520895
##########
accord-core/src/main/java/accord/local/Command.java:
##########
@@ -730,7 +734,7 @@ public void accept(SafeCommandStore safeStore)
if (cur == null)
{
// need to load; schedule execution for later
- safeStore.execute(this, this);
+ safeStore.execute(this,
this).begin(AsyncCallbacks.throwOnFailure());
Review Comment:
currently it means that calling the callback with a failure throws an
exception, presumably to be handled by the threads uncaught exception handler.
Having now put that in writing, that doesn't seem like the best approach, since
there are other use cases for submitting a failure (ie: in the case of accord
Timeouts).
Semantically, it means "start this chain, and I don't care about the result,
exception or otherwise", I'll change the name to noop and have it log exceptions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
