belliottsmith commented on code in PR #2057:
URL: https://github.com/apache/cassandra/pull/2057#discussion_r1053838707
##########
src/java/org/apache/cassandra/service/accord/AccordCommand.java:
##########
@@ -652,59 +654,66 @@ private boolean canApplyWithCurrentScope(SafeCommandStore
safeStore)
return true;
}
- private Future<Void> applyWithCorrectScope(CommandStore unsafeStore)
+ private AsyncResult<Void> applyWithCorrectScope(CommandStore unsafeStore)
Review Comment:
Agreed, I applied the same modification in my branch. It’s not optimal, but
it’s probably better than other approaches (another option is to offer a
flatMap function in CommandStore, but it would likely be implemented the same
way)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
