dcapwell commented on code in PR #18:
URL: https://github.com/apache/cassandra-accord/pull/18#discussion_r1061009383
##########
accord-core/src/test/java/accord/verify/StrictSerializabilityVerifier.java:
##########
@@ -562,9 +573,15 @@ public void checkForUnwitnessed(int start)
this.futureWrites = new FutureWrites(key, keyCount);
}
+ void print()
+ {
+ for (Map.Entry<Integer, UnknownStepHolder> e :
futureWrites.byWriteValue.entrySet())
+ logger.error("{}: {} -> ({}, {}, {})", key, e.getKey(),
e.getValue().writeValue, e.getValue().start, e.getValue().end);
+ }
+
private void updateSequence(int[] sequence, int maybeWrite)
{
- for (int i = 0, max = Math.min(sequence.length,
this.sequence.length) ; i < max ; ++i)
+ for (int i = 0, max = Math.min(sequence.length,
this.sequence.length); i < max; ++i)
Review Comment:
Our style guide does not cover this (see
https://cassandra.apache.org/_/development/code_style.html) and instead
delegates to Oracle's (see
http://java.sun.com/docs/codeconv/html/CodeConvTOC.doc.html). Based off
Oracle's style guide, we should not have the spaces
https://www.oracle.com/java/technologies/javase/codeconventions-statements.html#454
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
