isaacreath commented on code in PR #2058:
URL: https://github.com/apache/cassandra/pull/2058#discussion_r1061843057
##########
src/java/org/apache/cassandra/streaming/StreamSession.java:
##########
@@ -1027,9 +1022,30 @@ public void receive(IncomingStreamMessage message)
public void progress(String filename, ProgressInfo.Direction direction,
long bytes, long total)
{
ProgressInfo progress = new ProgressInfo(peer, index, filename,
direction, bytes, total);
+ updateMetricsOnProgress(progress);
streamResult.handleProgress(progress);
}
+ private void updateMetricsOnProgress(ProgressInfo progress)
+ {
+ ProgressInfo.Direction direction = progress.direction;
+ long lastSeenBytesStreamedForProgress =
lastSeenBytesStreamed.getOrDefault(progress, 0L);
+ long newBytesStreamed = progress.currentBytes -
lastSeenBytesStreamedForProgress;
+ if (direction == ProgressInfo.Direction.OUT)
+ {
+ StreamingMetrics.totalOutgoingBytes.inc(newBytesStreamed);
+ metrics.outgoingBytes.inc(newBytesStreamed);
+ }
+
+ else if (direction == ProgressInfo.Direction.IN)
+ {
+ StreamingMetrics.totalIncomingBytes.inc(newBytesStreamed);
+ metrics.incomingBytes.inc(newBytesStreamed);
+ }
+
+ lastSeenBytesStreamed.put(progress, lastSeenBytesStreamedForProgress +
newBytesStreamed);
Review Comment:
Yes, what we really care about to identify the uniqueness is the `(fileName,
direction)` tuple, so two maps could work.
I'm not really sure about why you're looking to store the
`progress.totalBytes` value in the `ins` and `outs` maps. The call to
`progress` _should_ always set the same value for a given `(fileName,
direction)` pair.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
